Reinstantiate QuaternionMovingAverage on reset #1283
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I beg you to put some description. |
|
I'm applying this to Stay Aligned v6.0 to see if the wider audience can repro the bug. I was able to repro it once, so I don't think it's fully fixed, but it seems to be much rarer. |
|
For context, when yaw/full resetting, sometimes the skeleton turns into a centaur. This used to happen quite consistently when going through Autobone (which does a full reset at the end). Now it seems to be rarer, but not completely fixed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try to fix the centaur issue by reinstantiating the QuaternionMovingAverage class intead of resetting its properties