Clean up skeleton interpolation and make tests #1349
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ButterscotchV
added
Area: Skeletal Model
I don't really know how it even managed to function before, this commit is currently untested
ButterscotchV
force-pushed
the
skeleton-interpolate
branch
from
008b56b to
4697f35
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skeleton intepolation handling is a bit of a mess right now, this PR cleans things up, documents parts of it that are confusing, and adds unit tests to ensure functionality.
This is yet to be tested, so it should remain a draft. Please wait until after v0.14.0 to merge this, as this is a scary change.