ESP32: Fix ADC/battery sense logic #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I could also reproduce this issue and this solved it for me perfectly |
|
This could break the normal ESP32. Please double check that the voltages are still correct on it. |
Confirmed working on Wroom 32 board http://cdn.kouno.xyz/2H6KA4So.png (edit because I don't know how to do links apparently >.>) |
ButterscotchV
approved these changes
Jan 14, 2024
nekomona
pushed a commit
to nekomona/SlimeVR-Tracker-ESP
that referenced
this pull request
Jan 30, 2024
* ESP32: Fix ADC voltage readings * Forgot endif oops * Refactor a little bit * Fix spelling of 'resolution'
l0ud
pushed a commit
to l0ud/SlimeVR-Tracker-ESP-BMI270
that referenced
this pull request
Apr 1, 2024
* ESP32: Fix ADC voltage readings * Forgot endif oops * Refactor a little bit * Fix spelling of 'resolution'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on ESP32-C3, default logic returns completely wrong values for voltage. This fixes it.