Add support for openssl 3 #9
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
commented
Jul 20, 2022
| @@ -119,6 +119,7 @@ def mac(data, nonce, additional_data) | |||
| @cipher.reset | |||
| @cipher.encrypt | |||
| @cipher.key = @key | |||
| @cipher.iv = "\x00" * 16 | |||
There was a problem hiding this comment.
I can't tell if this is a regression in OpenSSL's reset function or intentional behavior, but it's required to have the tests passing with OpenSSL 3.0 on Ubuntu 22.04 though
adfoster-r7
force-pushed
the
add-support-openssl-3
branch
from
6ebf948 to
2e2824f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #8
Related PRs:
@SmallLars I've made a quick PR to upgrade this library to support OpenSSL 3.0. At a high level:
coverallsas fails with newer versions of OpenSSL. Apparently it's now maintained under coveralls_reborn - but I didn't have access to the original Travis token to verify, and it appears to crash without that being present from what I could see.Tests passing: