source/futures: Fix handling of notified atomic
#227
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `notified` was cleared before the `self.source.process_events` call. This meant that it was cleared before reading from the ping source eventfd/pipe. This means that a call to `send()` form a waker in a different thread could call `ping()` before this has been read, and prevent future calls to `ping()`. But `process_events()` won't be woken again, freezing the executor. This seems to fix an issue I've seen in `cosmic-workspaces` when trying to use the `calloop` executor.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
notifiedwas cleared before theself.source.process_eventscall. This meant that it was cleared before reading from the ping source eventfd/pipe.This means that a call to
send()form a waker in a different thread could callping()before this has been read, and prevent future calls toping(). Butprocess_events()won't be woken again, freezing the executor.This seems to fix an issue I've seen in
cosmic-workspaceswhen trying to use thecalloopexecutor.