Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Be consistent with the documented options for authenticator #3388

Closed
wants to merge 1 commit into from

Conversation

rosner
Copy link

@rosner rosner commented Feb 7, 2025

Test Plan

  • acceptance tests

References

@rosner rosner changed the title Be consistent with the documented options for authenticator docs: Be consistent with the documented options for authenticator Feb 7, 2025
@sfc-gh-jcieslak
Copy link
Collaborator

sfc-gh-jcieslak commented Feb 7, 2025

Hey @rosner 👋
Thank You for your contribution. There's one thing that you need to do before we can accept this change. The guides should be changed in the templates/guides/, not docs/guides/ (docs are auto-generated based on templates). Please make the change in templates/guides, run make dev-setup (to install the doc-generating tool), and then make docs to generate docs that will appear in the docs/guides.
Also, please change the target branch to Snowflake-Labs:dev.

@sfc-gh-jmichalak
Copy link
Collaborator

Hi @rosner 👋 , thanks for the PR. I already fix this error in another PR: #3381. cc @sfc-gh-jcieslak

@rosner
Copy link
Author

rosner commented Feb 7, 2025

And there I was hoping for "open source fame" - hopes crushed, ego bruised, sad weekend ahead

@rosner rosner closed this Feb 7, 2025
@rosner rosner deleted the patch-1 branch February 7, 2025 13:15
@sfc-gh-asawicki
Copy link
Collaborator

@rosner we are open for contributions. I am sure there are other areas in this project where you can earn the fame ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants