Change switchboard and socket address types to bytes32 #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…that can touch multiple chains(non EVM also)
gwalen
force-pushed
the
dev-solana-update-types-bytes32
branch
from
2c372c8 to
3ef097d
Compare
arthcp
requested changes
May 16, 2025
| switchboard: watcherPrecompileConfig().switchboards(chainSlug_, sbType), | ||
| target: address(0), | ||
| switchboard: switchboardAddress, | ||
| target: toBytes32Format(address(0)), |
There was a problem hiding this comment.
Lets just do target: bytes32(0) instead of initializing address and then converting to bytes32.
There was a problem hiding this comment.
merging anyway since this is small
arthcp
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change is applied all places that can touch multiple chains(non EVM also)
Cr fixes: