Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix wrong plate y possition after switching profiles with different bed size #7923

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Noisyfox
Copy link
Collaborator

@Noisyfox Noisyfox commented Jan 5, 2025

There is a long lasting bug that sometimes when you open existing projects with >= 3 build plates, sometimes every models on plate other than the first row get shifted down, especially when you have multiple printer profiles with different plate size:
image
image

Notice that, in the first image, the gaps between plates are rectangles:
image
However once you switched between profiles that have different bed size, the gaps changed to squares, as shown in image 2:
image
The vertical spacing changes after swithing profiles, this includes opening 3mf files that has a different plate size than current profile, which causes everything get shifted.

This PR fixes this issue.

Please be aware, that the square gap is the correct behavior! The vertical gaps should have never been greater than the horizental gaps (which was a bug introduced in version 1.6.2). This means after this fix, all existing projects saved from version 1.6.2+ that have more than 2 plates will have the model shifted down (or up, depends on whether you switched the printer profile before saving), which is unfortunate but a necessary pain.

Fix #4016
Fix #7917

The fix is cherrypicked from BBS, thanks!

Jira: STUDIO-5287
Change-Id: I3add95f9f9345c14a48cc7467513d1b3ce95f4c9
(cherry picked from commit 9ce7de1)
Change-Id: Ieb856dff421d39694966e3c13c519f4ffa3da5c2
(cherry picked from commit 3289251)
@yomarcyo
Copy link

yomarcyo commented Jan 9, 2025

@Noisyfox thanks for taking care (I'm the one who reopened this issue). As I have no idea if the above is good, bad or nothing at all (I literally created an account on GitHub to file this issue), just one question: Is there anything I can do?

Again, thank you so much for taking care. I always thought: Why participate? Everyone will give less of a s**t. But apparently that's not the case and someone is actually looking into it.

Best,
Marc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants