Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create rule S5547: Cipher algorithms should be robust #4652

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Feb 6, 2025

You can preview this rule here (updated a few minutes after each push).

Review

A dedicated reviewer checked the rule description successfully for:

  • logical errors and incorrect information
  • information gaps and missing content
  • text style and tone
  • PR summary and labels follow the guidelines

@daniel-teuchert-sonarsource daniel-teuchert-sonarsource changed the title Create rule S5547 Create rule S5547: Add S5547 for Go Feb 7, 2025
@daniel-teuchert-sonarsource daniel-teuchert-sonarsource changed the title Create rule S5547: Add S5547 for Go Create rule S5547: Cipher algorithms should be robust Feb 7, 2025
Copy link

sonarqube-next bot commented Feb 7, 2025

Quality Gate passed Quality Gate passed for 'rspec-tools'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link

sonarqube-next bot commented Feb 7, 2025

Quality Gate passed Quality Gate passed for 'rspec-frontend'

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the other languages use GCM for a compliant solution, maybe we should follow suit?

Otherwise, LGTM! 👍

@daniel-teuchert-sonarsource
Copy link
Contributor

Most of the other languages use GCM for a compliant solution, maybe we should follow suit?

Otherwise, LGTM! 👍

In general I'd agree. However, in this case the necessary changes in the code examples could distract from the root change that is necessary to fix this issue.

@daniel-teuchert-sonarsource daniel-teuchert-sonarsource merged commit 162d5ba into master Feb 10, 2025
11 of 12 checks passed
@daniel-teuchert-sonarsource daniel-teuchert-sonarsource deleted the rule/S5547-add-go branch February 10, 2025 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants