SONAPPY-2876: Create rule S7504: Using \"list()\" on already iterable objects is unnecessary and inefficient #5035
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Seppli11
force-pushed
the
rule/add-RSPEC-S7504
branch
3 times, most recently
from
f6d4858 to
4a25880
Compare
Seppli11
force-pushed
the
rule/add-RSPEC-S7504
branch
from
4a25880 to
f8fde33
Compare
Seppli11
changed the title
Seppli11
changed the title
rules/S7504/python/metadata.json
Outdated
| @@ -0,0 +1,23 @@ | |||
| { | |||
| "title": "Using \"list()\" on already iterable objects is unnecessary and inefficient", | |||
There was a problem hiding this comment.
Here for the shape of the title it should be something like
| "title": "Using \"list()\" on already iterable objects is unnecessary and inefficient", | |
| "title": "Using \"list()\" on already iterable objects should be avoided", |
rules/S7504/python/rule.adoc
Outdated
|
|
||
| == Why is this an issue? | ||
|
|
||
| Using `list()` on already iterable objects adds meaningless code clutter that doesn't provide any functional value when wrapping an already iterable object. Additionally, it creates unnecessary overhead by generating an intermediate list in memory, which inefficiently consumes memory resources and can degrade performance, especially with large data structures. Iterating directly over the original object is cleaner and more efficient. |
There was a problem hiding this comment.
This looks good I would just specify more clearly that we mean in for loops. Maybe starting the sentence with: When using for loops...
Seppli11
force-pushed
the
rule/add-RSPEC-S7504
branch
from
b1ff123 to
58c8f3a
Compare
Seppli11
force-pushed
the
rule/add-RSPEC-S7504
branch
from
58c8f3a to
89d55da
Compare
|
|
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: