SONARPY-2865: Create rule S7508: Unnecessary <list/reversed/set/sorted/tuple> call within <list/set/sorted/tuple>() #5045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Seppli11
force-pushed
the
rule/add-RSPEC-S7508
branch
3 times, most recently
from
5fbb61a to
ada9bd7
Compare
Seppli11
force-pushed
the
rule/add-RSPEC-S7508
branch
from
ada9bd7 to
1eda634
Compare
Seppli11
changed the title
rules/S7508/python/rule.adoc
Outdated
|
|
||
| When the outer function is given a collection but could be given an iterable, the unnecessary cast to the collection should be removed. For example, in `sorted(list(iterable))`, the outer `sorted()` function can accept an iterable directly, so the inner `list()` call is redundant and should be removed. | ||
|
|
||
| When the function `sorted()` is casted to `list()`, remove the cast, since `sorted()` already returns a list. |
There was a problem hiding this comment.
as discussed we agreed to replace mentioning of the cast to something like passing as an argument
rules/S7508/python/rule.adoc
Outdated
|
|
||
| == Resources | ||
| === Documentation | ||
| * Python Documentation - https://docs.python.org/3/library/functions.html#list[list] |
There was a problem hiding this comment.
|
|
||
| list_of_list = list(list(iterable)) # Noncompliant | ||
| set_of_list = set(list(iterable)) # Noncompliant | ||
| sorted_of_list = list(sorted(iterable)) # Noncompliant |
There was a problem hiding this comment.
as discussed the sample code probably could show just single noncompliant case, otherwise it makes sense to split them by different diff-id code section pairs
rules/S7508/python/rule.adoc
Outdated
|
|
||
| list_of_list = list(iterable) # Noncompliant | ||
| set_of_list = set(iterable) # Noncompliant | ||
| sorted_of_list = sorted(iterable) # Noncompliant |
There was a problem hiding this comment.
remove the noncompliant comment
maksim-grebeniuk-sonarsource
requested changes
May 20, 2025
Seppli11
force-pushed
the
rule/add-RSPEC-S7508
branch
from
97b564d to
bdbcc1b
Compare
Seppli11
force-pushed
the
rule/add-RSPEC-S7508
branch
from
bdbcc1b to
6db810a
Compare
|
|
maksim-grebeniuk-sonarsource
approved these changes
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can preview this rule here (updated a few minutes after each push).
Review
A dedicated reviewer checked the rule description successfully for: