Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ffe-core): nye semantiske farger. [burde merges sammen med ffe-cards og fileupload] #2495

Open
wants to merge 6 commits into
base: develop
Choose a base branch
from

Conversation

tuva-odegard
Copy link
Contributor

Nye Semantiske farger i core. Gjelder overskrifter og flere skriftvarianter.
De eksisterende fargene er ikke depricated for å unngå for mye breaking changes.

Denne commiten påvirker så vidt jeg kan se Cards og FileUpload. Det er fordi den setter skiftfargen til hvit på dark mode, når de komponentene egentlig burde brukt fill. Så det er lurt å gjøre disse før man pusher denne committen, eller med lite mellomrom i alle fall.

@tuva-odegard tuva-odegard requested a review from a team as a code owner January 21, 2025 14:46
@hagenek hagenek changed the title feat(ffe-core): nye semantiske farger. feat(ffe-core): nye semantiske farger. [burde merges sammen med ffe-cards og fileupload] Jan 21, 2025
@dagfrode
Copy link
Contributor

Ser at det er vanskelig å jobbe på cards og FileUpload før denne er merget. så tar en frekk en og jobber videre på de i denne branchen så det blir merget samtidig og folker oppdages før merge.

@dagfrode dagfrode force-pushed the semantiske-farger-core branch from f0a4224 to 71fc20f Compare January 22, 2025 10:43
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2495.westeurope.2.azurestaticapps.net

@dagfrode dagfrode force-pushed the semantiske-farger-core branch from 71fc20f to 296b2e8 Compare January 22, 2025 10:56
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2495.westeurope.2.azurestaticapps.net

@dagfrode dagfrode force-pushed the semantiske-farger-core branch from 2d98f10 to 1ce3250 Compare January 24, 2025 09:42
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2495.westeurope.2.azurestaticapps.net

@dagfrode dagfrode force-pushed the semantiske-farger-core branch from 1ce3250 to 8f5f675 Compare January 28, 2025 14:17
BREAKING CHANGE: nye farger. Ingen ting å gjøre hvis man ikke har
justert fargene.
@dagfrode dagfrode force-pushed the semantiske-farger-core branch from 8f5f675 to 2aea4e4 Compare January 28, 2025 14:25
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2495.westeurope.2.azurestaticapps.net

@dagfrode dagfrode force-pushed the semantiske-farger-core branch from 2aea4e4 to a6b0ef8 Compare January 28, 2025 14:59
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2495.westeurope.2.azurestaticapps.net

@dagfrode dagfrode force-pushed the semantiske-farger-core branch from a6b0ef8 to f2bcc3f Compare January 28, 2025 15:18
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2495.westeurope.2.azurestaticapps.net

@dagfrode dagfrode changed the base branch from develop to semantiske-farger January 29, 2025 07:51
BREAKING CHANGE: Fjerner shadow som paramater siden cards går over til å bruke boarder i stede
BREAKING CHANGE: infører semantiske farger
@dagfrode dagfrode force-pushed the semantiske-farger-core branch from 118a904 to 1eab9df Compare January 31, 2025 11:42
@dagfrode dagfrode changed the base branch from semantiske-farger to develop January 31, 2025 14:03
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://black-beach-0d62d0d03-2495.westeurope.2.azurestaticapps.net

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants