-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Small packages fixes #36
base: master
Are you sure you want to change the base?
Conversation
Just wondering if this is going to land soon? I believe the missing dependency is preventing me from installing heml with pnpm. (it does technically install, but running |
Hey Michael, sorry about that! Can you share the error you're getting? I'll resolve the conflicts on this and get it merged today! |
No worries! I’ve temporarily worked around the issue, so it’s no biggie. $ heml -h
module.js:472
throw err;
^
Error: Cannot find module 'postcss-selector-parser'
at Function.Module._resolveFilename (module.js:470:15)
at Function.Module._load (module.js:418:25)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Object.<anonymous> (/path/to/node_modules/.registry.npmjs.org/@heml/styles/1.1.2/node_modules/@heml/styles/build/plugins/postcss-element-expander/tagAliasSelectors.js:35:30)
at Module._compile (module.js:571:32)
at Object.Module._extensions..js (module.js:580:10)
at Module.load (module.js:488:32)
at tryModuleLoad (module.js:447:12)
at Function.Module._load (module.js:439:3) |
I should also add that I love this project, so thanks for your work! :) |
I'm glad it helps! Any chance you can test this branch out before I merge it? You can follow the instructions here. Just be sure to check out the |
Okay, so I followed those instructions, and it worked on both the
After I installed those missing dependencies I could successfully run |
Any news about this PR being merge? @avigoldman We cannot use |
There was an unused package (
postcss-shorthand-expand
) and a used package that was installed by a dependency (postcss-selector-parser
) that should have been installed.I also installed
babel-runtime
to all the packages since they could be installed independently of the mainheml
package.