-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix critical security vulnerabilities #98
Open
karlhorky
wants to merge
20
commits into
SparkPost:master
Choose a base branch
from
karlhorky:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.4...4.17.13) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.4...4.17.13) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.4...4.17.13) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.4...4.17.13) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.4...4.17.13) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [lodash](https://github.com/lodash/lodash) from 4.17.4 to 4.17.13. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.4...4.17.13) Signed-off-by: dependabot[bot] <[email protected]>
…/packages/heml-inline/lodash-4.17.13 Bump lodash from 4.17.4 to 4.17.13 in /packages/heml-inline
…/packages/heml-render/lodash-4.17.13 Bump lodash from 4.17.4 to 4.17.13 in /packages/heml-render
…ost#3) Bump lodash from 4.17.4 to 4.17.13 in /packages/heml-validate
Bump lodash from 4.17.4 to 4.17.13 in /packages/heml-utils
Bump lodash from 4.17.4 to 4.17.13 in /packages/heml-parse
Bumps [nwmatcher](https://github.com/dperini/nwmatcher) from 1.4.3 to 1.4.4. - [Release notes](https://github.com/dperini/nwmatcher/releases) - [Commits](https://github.com/dperini/nwmatcher/commits) Signed-off-by: dependabot[bot] <[email protected]>
Bumps [diff](https://github.com/kpdecker/jsdiff) from 3.4.0 to 3.5.0. - [Release notes](https://github.com/kpdecker/jsdiff/releases) - [Changelog](https://github.com/kpdecker/jsdiff/blob/master/release-notes.md) - [Commits](kpdecker/jsdiff@v3.4.0...v3.5.0) Signed-off-by: dependabot[bot] <[email protected]>
…n/nwmatcher-1.4.4 Bump nwmatcher from 1.4.3 to 1.4.4
Bump diff from 3.4.0 to 3.5.0
jgzamora
approved these changes
Feb 19, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR @karlhorky , LGTM! I'm not super used to working on this project so it might take me a bit to ramp up on the publishing process. Once I figure it out I will merge and publish
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there, first of all, thanks for this project! Nice to see work being done in the email ecosystem :)
There are a number of security vulnerabilities in the old dependencies here.
This pull request fixes some of the easier ones (fixed via
npm audit fix
) and also the critical vulnerability inopen
.This is also affecting other projects which depend on
heml
, such as this one where I have been contributing:Jinksi/netlify-cms-react-starter#26 (comment)
cc @jgzamora @avigoldman @shrirupa @gfriedmansp @nicklemmon