Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: reduce string allocation for decompression #91

Closed
wants to merge 2 commits into from
Closed

feat: reduce string allocation for decompression #91

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8d635c6
feat: reduce string allocation for decompression
SpringMT May 24, 2024
4377656
fix: SEGV
SpringMT May 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 7 additions & 9 deletions ext/zstdruby/zstdruby.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,23 +88,21 @@ static VALUE rb_compress_using_dict(int argc, VALUE *argv, VALUE self)
static VALUE decompress_buffered(ZSTD_DCtx* dctx, const char* input_data, size_t input_size)
{
ZSTD_inBuffer input = { input_data, input_size, 0 };
VALUE result = rb_str_new(0, 0);

size_t const buffOutSize = ZSTD_DStreamOutSize();
VALUE output_string = rb_str_buf_new(buffOutSize);
ZSTD_outBuffer output = { RSTRING_PTR(output_string), buffOutSize, 0 };
while (input.pos < input.size) {
ZSTD_outBuffer output = { NULL, 0, 0 };
output.size += ZSTD_DStreamOutSize();
VALUE output_string = rb_str_new(NULL, output.size);
output.dst = RSTRING_PTR(output_string);

size_t ret = zstd_stream_decompress(dctx, &output, &input, false);
if (ZSTD_isError(ret)) {
ZSTD_freeDCtx(dctx);
rb_raise(rb_eRuntimeError, "%s: %s", "ZSTD_decompressStream failed", ZSTD_getErrorName(ret));
}
rb_str_cat(result, output.dst, output.pos);
rb_str_modify_expand(output_string, buffOutSize);
output.dst = output.dst + output.size;
}
rb_str_set_len(output_string, output.pos);
ZSTD_freeDCtx(dctx);
return result;
return output_string;
}

static VALUE rb_decompress(int argc, VALUE *argv, VALUE self)
Expand Down
Loading