Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW PROVIDER: CNR (test) #3222

Conversation

tlimoncelli
Copy link
Contributor

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes detected by Check Git Status Action

@KaiSchwarz-cnic
Copy link
Contributor

KaiSchwarz-cnic commented Dec 6, 2024

@tlimoncelli

I wonder as the tests passed multiple times yesterday evening and they still pass on my end.
Also I double checked if I am using either an outdated branch or having some uncommitted changes. Nothing applies.

...
--- PASS: TestDualProviders (3.83s)
=== RUN   TestNameserverDots
No nameservers found
=== RUN   TestNameserverDots/No_trailing_dot_in_nameserver
--- PASS: TestNameserverDots (0.11s)
    --- PASS: TestNameserverDots/No_trailing_dot_in_nameserver (0.00s)
PASS
ok      github.com/StackExchange/dnscontrol/v4/integrationTest  299.639s

this is how I am running them:

export CNR_ENTITY='OTE'
export CNR_UID='qmtest:REDACTED'
export CNR_PW='REDACTED'
export CNR_DOMAIN="dnscontroltest-cnr.com"
cd integrationTest
go test -v -failfast -verbose -provider CNR

Is there any difference between how the workflow runs the test vs. how we're manually doing that?
I am happy to work on all that, but how to get that reproduced?

@KaiSchwarz-cnic
Copy link
Contributor

I also tried replicating what the workflow is doing:

image

no idea ...

@KaiSchwarz-cnic
Copy link
Contributor

KaiSchwarz-cnic commented Dec 6, 2024

going for your branch now, maybe that's the difference finally ... hmm I have no access on that one in our fork.

I synced/updated our fork now and rebased our branch. Tests did still pass.

@tlimoncelli tlimoncelli force-pushed the centralnicgroup-opensource-RSRMID-2019-dns-control-for-cnr branch from 1a128e9 to e39557e Compare December 6, 2024 15:20
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes detected by Check Git Status Action

@tlimoncelli tlimoncelli closed this Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants