-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests FHIRResource
and its extensions
#28
Conversation
b71333d
to
d607628
Compare
d607628
to
2fa405c
Compare
FHIRResource
and its extensions.FHIRResource
and its extensions.
FHIRResource
and its extensions.FHIRResource
and its extensions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was waiting for #26 to be merged so I could test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jdisho for the extensive tests, they were quite tedious to write for sure but it helps us to push the test coverage! 🚀
Had some minor comments, mostly regarding formatting and styling. Please resolve all outstanding Linter warnings and compile errors, then we should be good to merge!
Thanks for the feedback @philippzagar ✨ |
Thank you @jdisho & @philippzagar! |
This reverts commit 9893669.
1032031
to
69b63b3
Compare
69b63b3
to
9e470ca
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #28 +/- ##
===========================================
+ Coverage 34.97% 54.67% +19.71%
===========================================
Files 21 21
Lines 1467 1467
===========================================
+ Hits 513 802 +289
+ Misses 954 665 -289 see 11 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
This is ready but let me know if there is anything else. |
@philippzagar - Any new input from your side or should I merge it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @jdisho! 🚀
At some point soon, we'll lift all of our Spezi modules to swift-testing, we'll then also do it for this code!
@jdisho One more thing, please ensure that all commits on the respective branch are properly signed. The later commits on here are signed, however, the first ones are not. |
Thank you 🫶 @philippzagar |
Write tests for
FHIRResource
and its extensions.♻️ Current situation & Problem
The
FHIRResource
class and its extensions currently have 0% test coverage. We should increase the code coverage as much as possible, to ensure long-term maintainability.⚙️ Release Notes
FHIRResource
,FHIRResource+Search
, andResourceProxy+DisplayName
.FHIRResource+Category
tests, it's best to wait until PRFHIRStore
actor isolation #26 is merged into the main branch, avoiding any potential conflicts or inconsistencies.📚 Documentation
Comments are added throughout the code.
✅ Testing
Aim for >90% code coverage, but >80% is acceptable in this case.
📝 Code of Conduct & Contributing Guidelines
By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines: