Bug with health actuator showDetails

[TimHess]

Describe the bug

management:endpoints:health:showDetails does not affect whether details of the health check are included in the response.

Steps to reproduce

Steps to reproduce the behavior:

1. Find test ...Endpoint.Test.Actuators.Health.EndpointMiddlewareTest.HealthActuator_ReturnsOnlyStatusWhenAuthorized
2. Observe details in the health object during debugging

Expected behavior

The "details" property in the response should be empty when showDetails is Never or the user details in the request do not fit the configuration for WhenAuthorized

Additional detail

Steeltoe v4 code (HealthEndpointHandler.cs):

ShowDetails showDetails = endpointOptions.ShowDetails;
if (showDetails != ShowDetails.Never && (showDetails != ShowDetails.WhenAuthorized || healthRequest.HasClaim))
{
    foreach (string group in endpointOptions.Groups.Select(group => group.Key))
    {
        response.Groups.Add(group);
    }
}

Steeltoe v3 code:

var showDetails = Options.ShowDetails;
if (showDetails == ShowDetails.Never || (showDetails == ShowDetails.WhenAuthorized && !securityContext.HasClaim(Options.Claim)))
{
    response.Details = new Dictionary<string, object>();
}
else
{
    response.Groups = Options.Groups.Select(g => g.Key);
}

[TimHess]

In my quick local test, showDetails works as expected when this is added after the snippet in HealthEndpointHandler

else
{
    response.Details.Clear();
}

[TimHess]

Potentially related...

Given this response:

{
    "status": "UP",
    "details": {
        "diskSpace": {
            "status": "UP",
            "total": 1001462427648,
            "free": 256919261184,
            "threshold": 10485760
        },
        "readiness": {
            "status": "UP",
            "ReadinessState": "ACCEPTING_TRAFFIC"
        },
        "MySQL": {
            "status": "UP",
            "host": "localhost"
        },
        "liveness": {
            "status": "UP",
            "LivenessState": "CORRECT"
        }
    }
}

SBA shows this in the UI:

Compared with a Spring demo app:

{
    "status": "UP",
    "details": {
        "diskSpace": {
            "status": "UP",
            "details": {
                "total": 1001462427648,
                "free": 257143635968,
                "threshold": 10485760,
                "path": "C:\\Users\\timhe\\Downloads\\demo\\.",
                "exists": true
            }
        },
        "ping": {
            "status": "UP"
        }
    }
}

Which looks like this:

I don't know if any of this is relevant to #1367, but for both of these examples, the request included an Accept header with value application/vnd.spring-boot.actuator.v2+json,application/vnd.spring-boot.actuator.v1+json,application/json