-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ShowDetails in /health #1421
Merged
Merged
ShowDetails in /health #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use Never as the default
TimHess
added
Type/bug
Something isn't working
Component/Management
Issues related to Steeltoe Management (actuators)
ReleaseLine/4.x
Identified as a feature/fix for the 4.x release line
labels
Jan 8, 2025
bart-vmware
reviewed
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Basically looks good, added some notes.
src/Management/src/Endpoint/Actuators/Health/HealthEndpointOptions.cs
Outdated
Show resolved
Hide resolved
src/Management/test/Endpoint.Test/Actuators/Health/EndpointMiddlewareTest.cs
Outdated
Show resolved
Hide resolved
src/Management/test/Endpoint.Test/Actuators/Health/EndpointMiddlewareTest.cs
Outdated
Show resolved
Hide resolved
src/Management/test/Endpoint.Test/Actuators/Health/EndpointMiddlewareTest.cs
Outdated
Show resolved
Hide resolved
src/Management/test/Endpoint.Test/Actuators/Health/EndpointMiddlewareTest.cs
Outdated
Show resolved
Hide resolved
src/Management/src/Endpoint/Actuators/Health/HealthEndpointHandler.cs
Outdated
Show resolved
Hide resolved
bart-vmware
approved these changes
Jan 13, 2025
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component/Management
Issues related to Steeltoe Management (actuators)
ReleaseLine/4.x
Identified as a feature/fix for the 4.x release line
Type/bug
Something isn't working
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug where health details aren't cleared out if they shouldn't be returned.
Change default value for ShowDetails to Never
Resolves #1406, Fixes #1411
Documentation updated in SteeltoeOSS/Documentation#336
Quality checklist
If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.