Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShowDetails in /health #1421

Merged
merged 9 commits into from
Jan 13, 2025
Merged

ShowDetails in /health #1421

merged 9 commits into from
Jan 13, 2025

Conversation

TimHess
Copy link
Member

@TimHess TimHess commented Jan 8, 2025

Description

Fix bug where health details aren't cleared out if they shouldn't be returned.
Change default value for ShowDetails to Never

Resolves #1406, Fixes #1411

Documentation updated in SteeltoeOSS/Documentation#336

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

@TimHess TimHess added Type/bug Something isn't working Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/4.x Identified as a feature/fix for the 4.x release line labels Jan 8, 2025
@TimHess TimHess added this to the 4.0.0-m1 milestone Jan 8, 2025
@TimHess TimHess self-assigned this Jan 8, 2025
@TimHess TimHess requested a review from bart-vmware January 8, 2025 16:50
Copy link
Member

@bart-vmware bart-vmware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Basically looks good, added some notes.

@TimHess TimHess requested a review from bart-vmware January 9, 2025 15:59
@TimHess TimHess merged commit da3d465 into main Jan 13, 2025
19 checks passed
@TimHess TimHess deleted the bug/showDetails branch January 13, 2025 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component/Management Issues related to Steeltoe Management (actuators) ReleaseLine/4.x Identified as a feature/fix for the 4.x release line Type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug with health actuator showDetails Health Endpoint default for ShowDetails should be Never
2 participants