Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address PyOpenSci comments #103

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Address PyOpenSci comments #103

merged 3 commits into from
Sep 10, 2024

Conversation

matteobachetti
Copy link
Member

@matteobachetti matteobachetti commented Sep 10, 2024 •
edited
Loading

taldcroft
taldcroft approved these changes Sep 10, 2024
View reviewed changes
Copy link

@taldcroft taldcroft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both notebooks run to completion now for me, so good from my perspective.

@matteobachetti matteobachetti merged commit 29875e8 into main Sep 10, 2024
1 check passed
@matteobachetti matteobachetti deleted the address_pyopensci_comments branch September 10, 2024 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taldcroft taldcroft taldcroft approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken link in multitaper_example.ipynb Lightcurve tutorial notebook fails
2 participants
@matteobachetti @taldcroft