Buyback and Burn #1318
Open
Buyback and Burn #1318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fork only necessary osmomath files - fork cl pool types and price calc func
…oracle.proto and regenerate go bindings
Removes redundant 'stride' and 'v1beta1' segments from API paths to make them cleaner and more consistent - /icqoracle/price - /icqoracle/prices - /icqoracle/params
Removes 'stride/x/' prefix from amino message names to maintain consistent naming for: - MsgRegisterTokenPriceQuery - MsgRemoveTokenPrice
to share code between msg validation and genesis validation
sampocs
reviewed
Dec 19, 2024
Comment on lines
+20
to
+22
| func TokenPriceQueryKey(baseDenom, quoteDenom, poolId string) []byte { | ||
| return []byte(fmt.Sprintf("%s|%s|%s", baseDenom, quoteDenom, poolId)) | ||
| } |
There was a problem hiding this comment.
should this be TokenPriceKey instead to line up with the keepers and struct type?
Comment on lines
+24
to
+26
| func TokenPriceByDenomKey(baseDenom string) []byte { | ||
| return []byte(baseDenom) | ||
| } |
There was a problem hiding this comment.
I think you can remove this and just do the []byte(TokenPrice.BaseDenom) in the keepers
- Introduces v25 upgrade handler with ICQOracle parameter initialization - Adds new module store upgrades for icqoracle, strdburner, and auction Initial ICQOracle parameters: - 5 min update and expiration intervals - 2 min ICQ timeout - Osmosis chain and connection configurations
…om expiring before icq comes back
Corrects the mathematical comparison for bid price validation to properly compare payment amount against selling amount multiplied by floor price. Adds clarifying comments explaining the price conversion between tokens and the purpose of MinPriceMultiplier to improve code readability.
- add icqoracle msgserver tests - fix remove token query - refactor keeper functions to get the 3 key values rather than the token price struct
assafmo
force-pushed
the
buyback-and-burn
branch
from
f51792c to
e3eb449
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.