Update Lionweb and the Starlasu implementation in Lionweb #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…st Kolasu 1.5, also addressing #79
ftomassetti
reviewed
Feb 14, 2025
There was a problem hiding this comment.
I wonder if we should have a JSON file saved somewhere and just load it here (just sharing a thought, I do not expect this to be changed in this PR)
ftomassetti
reviewed
Feb 14, 2025
| @@ -29,7 +30,7 @@ import {STARLASU_LANGUAGE} from "./lionweb-starlasu-language"; | |||
| export {STARLASU_LANGUAGE} from "./lionweb-starlasu-language"; | |||
|
|
|||
| export const ASTNode = STARLASU_LANGUAGE.entities.find(e => e.name == "ASTNode")! as Concept; | |||
| export const PositionFeature = ASTNode.features.find(f => f.name == "position")! as Containment; | |||
| export const PositionFeature = ASTNode.features.find(f => f.name == "position")! as Property; | |||
| export const PositionClassifier = PositionFeature.type!; | |||
There was a problem hiding this comment.
I would not call those Classifiers as Classifier is a Concept, an Interface or an Annotation. This is a PrimitiveType
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #79