Roast v0.5.0, faster input conversion #1293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using the new `ToOPAInput` function from RoAST cuts the number of allocations related to input transformation in half. This doesn't constitute a bottleneck for command line linting, but will help the language server process files as quickly as possible on changes. Also convert a few bytes/string conversions to allocation-free variants. I don't think these matter much, but having them around will help remind us that's an option for when it does matter. Signed-off-by: Anders Eknert <[email protected]>
anderseknert
force-pushed
the
bump-roast
branch
from
aa6edd0 to
518f36c
Compare
srenatus
reviewed
Dec 12, 2024
| @@ -133,7 +134,7 @@ func Plan(ctx context.Context, path, rego string, usePrint bool) (string, error) | |||
| { | |||
| URL: "/url", | |||
| Path: path, | |||
| Raw: []byte(rego), | |||
There was a problem hiding this comment.
So there's one direction where no copy or allocation is happening, and I believe it's string -> []byte. Random SO answer. So does StringToByteSlice actually do something for us? 🤔
srenatus
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the new
ToOPAInputfunction from RoAST cuts the number of allocations related to input transformation in half.This doesn't constitute a bottleneck for command line linting, but will help the language server process files as quickly as possible on changes.
Also convert a few bytes/string conversions to allocation-free variants. I don't think these matter much, but having them around will help remind us that's an option for when it does matter.