Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature:Autograding] Fixed a typo in the workflow file #51

Merged
merged 4 commits into from
Sep 16, 2024

Conversation

ION606
Copy link
Contributor

@ION606 ION606 commented Sep 13, 2024

Please check if the PR fulfills these requirements:

  • Tests for the changes have been added/updated (if possible)
  • Documentation has been updated/added if relevant

What is the current behavior?

There is a duplicate Docker Build and Push workflow

What is the new behavior?

There will no longer be a duplicate Docker Build and Push workflow

Other information?

@ION606 ION606 changed the title [Bugfix: Autograder]: Fixed a typo in the workflow file [Feature:Autograding] Fixed a typo in the workflow file Sep 13, 2024
@ION606 ION606 self-assigned this Sep 13, 2024
.github/workflows/docker-build-pr.yml Outdated Show resolved Hide resolved
@ION606 ION606 requested a review from cjreed121 September 15, 2024 03:00
Copy link
Member

@cjreed121 cjreed121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/Submitty/DockerImagesRPI mirrors the same workflows as this repo. Would you also be able to make a PR there for this too?

@ION606
Copy link
Contributor Author

ION606 commented Sep 15, 2024

https://github.com/Submitty/DockerImagesRPI mirrors the same workflows as this repo. Would you also be able to make a PR there for this too?

sure
edit: Submitty/DockerImagesRPI#29

@ION606 ION606 removed the request for review from bmcutler September 15, 2024 03:33
@bmcutler bmcutler merged commit 2f15550 into Submitty:main Sep 16, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants