Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix:InstructorUI] Photo Scraper overhaul #30

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Conversation

powe97
Copy link
Contributor

@powe97 powe97 commented Jul 15, 2024

This PR updates the photo scraper to the latest Selenium and fixes the login process. For now, it also makes the scraper fetch CRNs from the SIS Class Search page. The purpose of doing this is to make the login functionality testable for non-instructors.

@powe97 powe97 marked this pull request as ready for review July 16, 2024 14:57
@dorian451 dorian451 self-requested a review July 16, 2024 15:26
Copy link

@dorian451 dorian451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't test the actual photo scraping part since I don't have the required permissions on SIS but testing with --crns_only works (on linux)

@micpap25 micpap25 requested review from micpap25 and ziesski July 16, 2024 16:58
Copy link

@micpap25 micpap25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

crns_only works for me on Windows

PhotoScraper/RPI_SIS_PhotoScraper.py Outdated Show resolved Hide resolved
PhotoScraper/RPI_SIS_PhotoScraper.py Outdated Show resolved Hide resolved
@bmcutler bmcutler changed the title [Bugfix:Photoscraper] Photo Scraper overhaul [Bugfix:InstructorUI] Photo Scraper overhaul Jul 17, 2024
Copy link
Member

@bmcutler bmcutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it, photoscraping works!

PhotoScraper/RPI_SIS_PhotoScraper.py Outdated Show resolved Hide resolved
@powe97 powe97 requested review from ziesski and bmcutler July 18, 2024 16:03
@bmcutler bmcutler merged commit 3892767 into main Jul 18, 2024
1 check passed
@powe97 powe97 deleted the update_photo_scraper branch July 19, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants