-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix:InstructorUI] Photo Scraper overhaul #30
Conversation
… for non-instructors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't test the actual photo scraping part since I don't have the required permissions on SIS but testing with --crns_only
works (on linux)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crns_only
works for me on Windows
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested it, photoscraping works!
This PR updates the photo scraper to the latest Selenium and fixes the login process. For now, it also makes the scraper fetch CRNs from the SIS Class Search page. The purpose of doing this is to make the login functionality testable for non-instructors.