Allow build/running on WSL/Mono #9119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add System.Resources.Extensions package and optimize resources Added System.Resources.Extensions to Directory.Packages.props and updated related project files to enhance resource handling. Enabled preserialized resource generation in SubtitleEdit.csproj for potential performance improvements. Removed unused App.config reference from Test.csproj for cleanup purposes.
Included System.Resources.Extensions in the installer and both build scripts to ensure consistent packaging of required dependencies. This addresses any potential runtime issues caused by the missing DLL. No other files were modified.
|
Would this make it possible to run the unit tests as a Github action (on Linux)? |
# Conflicts: # Directory.Packages.props # src/Tests/Tests.csproj
I think so, haven't test it though. I was able to run tests using Ubuntu on WSL with mono. There are the failing tests: Merry Christmas 🎄 and Happy New Year 🎆 |
|
Happy New Year and blessed holidays and days to come to you as well Ivandro and Nikolaj! |
|
Links to #9175 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit ensures that the
System.Resources.Extensionslibrary is included in both the build process and the installer scripts to address potential runtime issues from the absence of this dependency. Specifically, the library is added to the files copied during the build (build.batandbuild_beta.bat) and to the application's installer configuration to ensure it is properly distributed with the application.Related to
#9107