Make collapse/display templates work in dark mode #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In dark mode, the display templates still have a light background, and stand out far too much. This adds CSS to change the `bg-light` class for the collapse and display templates to the dark-mode colors when `data-bs-theme=dark`. See jhpyle/docassemble#718 for a discussion on a suggested fix for a similar issue, which resulted in the suggested workaround here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dark mode, the display templates still have a light background, causing contrast issues with the text inside, and in general stands out far too much against the page background. This adds CSS to change the
bg-lightclass for the collapse and display templates to the dark-mode colors whendata-bs-theme=dark.See jhpyle/docassemble#718 for a discussion on a suggested fix for a similar issue, which resulted in the suggested workaround here.
An image of the dark mode display template without this PR:
An image of the dark mode display template with this PR: