Merge pull request #760 from mjkillough/pca9685

Fix full on/off in pca9685.
SuperHouse · Aug 17, 2020 · 503e66a · 503e66a
2 parents 48e4132 + acfd46a
commit 503e66a
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/extras/pca9685/pca9685.c b/extras/pca9685/pca9685.c
@@ -185,6 +185,7 @@ void pca9685_set_pwm_value(i2c_dev_t *dev, uint8_t channel, uint16_t val)
     if (val == 0)
     {
         // Full off
+        // Takes precedence over full on.
         write_reg(dev, reg + OFFS_REG_LED_OFF, LED_FULL_ON_OFF);
     }
     else if (val < 4096)
@@ -195,6 +196,8 @@ void pca9685_set_pwm_value(i2c_dev_t *dev, uint8_t channel, uint16_t val)
     }
     else
     {
+        // Clear full off, as it takes precedence over full on.
+        write_reg(dev, reg + OFFS_REG_LED_OFF, 0);
         // Full on
         write_reg(dev, reg + OFFS_REG_LED_ON, LED_FULL_ON_OFF);
     }