chore!: adopt slog #173
Merged
chore!: adopt slog #173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the work was done by the conversion script, I only tidied up/decorated a few error logs: https://gist.github.com/tjhop/49f96fb7ebbe55b12deee0b0312d8434 Other changes include: - bump to go1.22 as minimum in go.mod (ci already built with 1.22) - updates to prometheus/{common,exporter-toolkit,client_golang} - drop go-kit/log configs from linter - enable sloglint Signed-off-by: TJ Hoplock <[email protected]>
tjhop
force-pushed
the
chore/adopt-slog
branch
from
b99540f to
f31169a
Compare
|
🙃 🙃 🙃 |
SuperQ
approved these changes
Dec 12, 2024
SuperQ
added a commit
that referenced
this pull request
Jan 21, 2025
Note that this version now uses a BPF filter in privileged mode to improve perforamnce. * [CHANGE] Update logging to Go slog library #173 * [ENHANCEMENT] Improve performance #178 Signed-off-by: SuperQ <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the work was done by the conversion script, I only tidied
up/decorated a few error logs:
https://gist.github.com/tjhop/49f96fb7ebbe55b12deee0b0312d8434
Other changes include: