Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance #178

Merged
merged 1 commit into from
Jan 21, 2025
Merged

Improve performance #178

merged 1 commit into from
Jan 21, 2025

Conversation

SuperQ
Copy link
Owner

@SuperQ SuperQ commented Jan 21, 2025

Bump pro-bing to integrate upstream BPF filter improvement.

  • Add automatic handling of GOMAXPROCS.
  • Document GOMAXPROCS.

@SuperQ SuperQ force-pushed the superq/bump_pro-bing branch from 4a9ad3d to 8dcd83a Compare January 21, 2025 11:42
Bump pro-bing to integrate upstream BPF filter improvement.
* Add automatic handling of GOMAXPROCS.
* Document GOMAXPROCS.

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ force-pushed the superq/bump_pro-bing branch from 8dcd83a to c1e8d9e Compare January 21, 2025 11:42
@SuperQ
Copy link
Owner Author

SuperQ commented Jan 21, 2025

Here is a performance comparison with the last release:
image

The test is on a 13th Gen Intel(R) Core(TM) i7-1365U 12-CPU system, with the smokeping prober configured to ping 100 localhost IPs.

The top line is the smokeping prober, the lower line is the Prometheus monitoring it.

  • The first section (over 1.0 CPUs) is the old release (GOMAXPROCS=12).
  • The second section (0.45 CPUs) is the old release with GOMAXPROCS=2.
  • The third section (0.35 CPUs) is the new pro-bing library with GOMAXPROCS=2.
  • The last section (0.25 CPUs) is the new pro-bing library with GOMAXPROCS=1.

@SuperQ SuperQ merged commit 499ed20 into master Jan 21, 2025
5 checks passed
@SuperQ SuperQ deleted the superq/bump_pro-bing branch January 21, 2025 11:51
SuperQ added a commit that referenced this pull request Jan 21, 2025
Note that this version now uses a BPF filter in privileged mode to improve perforamnce.

* [CHANGE] Update logging to Go slog library #173
* [ENHANCEMENT] Improve performance #178

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ mentioned this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant