946147: Update Stock Market Use Case Sample Based on UX Review. #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description
The stock market use case sample had multiple UI and functional inconsistencies, including improper spacing, unclear borders, inconsistent button styles, and inadequate differentiation of stock price trends (high/low values). Additionally, real-time updates.
Root cause
The UI did not fully adhere to the Figma specifications, leading to issues with spacing, card alignment, border visibility, and button styles. The stock price high/low indicators were not visually distinct due to missing color differentiation. On the functional side, the WebSocket event handling for real-time updates was incorrect.
Reason for not identifying earlier
Find how it was missed in our earlier testing and development by analyzing the below checklist. This will help prevent similar mistakes in the future.
Guidelines/documents are not followed
Common guidelines / Core team guideline
Specification document
Requirement document
Guidelines/documents are not given
Common guidelines / Core team guideline
Specification document
Requirement document
Reason:
Guidelines/documents are not given - Requirement document
Action taken:
SB automation cover this case.
Related areas:
button, card and carousel component, value display, alignments
Is it a breaking issue?
NA
Solution description
Output screenshots
Before
After
Areas affected and ensured
Stock market use case sample. Ensured with UX team figma.
https://www.figma.com/design/af3I5MGKUJqahGPDHtqjXR/branch/2DwTZiuVqwaSA8PGgkaFRp/Tailwind-CSS-V3?node-id=24480-1117&p=f&t=NHtAV9oVArGblIdd-0
Additional checklist
This may vary for different teams or products. Check with your scrum masters.
Did you run the automation against your fix? - NA
Is there any API name change? - NA
Is there any existing behavior change of other features due to this code change? - NA
Does your new code introduce new warnings or binding errors? - NA
Does your code pass all FxCop and StyleCop rules? - NA
Did you record this case in the unit test or UI test? - NA
This issue applicable for blazor? - No