Fix dependency list #6411
Merged
Fix dependency list #6411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- script was lacking some dependencies (not recursing into all dependent Makefiles)
- was not updated in SynoCommunity#6255
- remove duplicates in cumulated dependencies early
smaarn
reviewed
Jan 25, 2025
- remove obsolete unique filtering - apply python and ffmpeg dependencies on top level only
This reverts commit 2cd7349.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
follow up to #6255
not all dependencies were found.
also the former implementation with make dependecy-list did not find all dependencies
Remarks
cross/berkeleyis such a dependency that was lacking in the dependency list (it was lacking in the pre #6255 version too).Fixes #
Checklist
all-supportedcompleted successfullyType of change