Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staking rewards #523

Merged
merged 73 commits into from
Jul 24, 2020
Merged

Staking rewards #523

merged 73 commits into from
Jul 24, 2020

Conversation

hav-noms
Copy link
Contributor

@hav-noms hav-noms commented May 18, 2020

Also made the Distribution Authority public as we couldn't see it before.
This now needs

  • Unit Tests migrated
  • Deploy Script to accomodate Deploying instances
  • Update deployed contracts to include
  • 1. uniswap sETH
  • 2. Curve Pool
  • 3. iETH Rewards
  • 4. Balancer Rewards
  • KOVAN ENV Moved tasks to seperate issue Deploy StakingRewards on KOVAN #610
  • Deploy Uniswap V2 sXAU/USDC UNI-V2 TESTNETS
  • Deploy StakingRewards for sXAU/USDC exchange and SNX as rewards
  • Deploy StakingRewards for iETH as staking token and SNX as rewards
  • ping me and I'll configure RewardsDistribution for testing

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #523 into develop will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #523      +/-   ##
===========================================
+ Coverage    99.46%   99.47%   +0.01%     
===========================================
  Files           44       45       +1     
  Lines         2792     2856      +64     
  Branches       395      403       +8     
===========================================
+ Hits          2777     2841      +64     
  Misses          15       15              
Impacted Files Coverage Δ
contracts/RewardsDistribution.sol 100.00% <ø> (ø)
contracts/StakingRewards.sol 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39b7f22...296866a. Read the comment docs.

@hav-noms hav-noms requested review from jacko125 and jjgonecrypto May 18, 2020 06:27
@jjgonecrypto
Copy link
Contributor

Looks like @thekevinbrown updated Solidifier, now we just need him to publish it to npm... CoinageCrypto/solidifier#1

@hav-noms hav-noms requested a review from jjgonecrypto July 23, 2020 03:20
@hav-noms hav-noms merged commit c4dd441 into develop Jul 24, 2020
@hav-noms hav-noms deleted the staking-rewards branch July 24, 2020 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants