Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing redundant Synthetix reference from Synths #584

Merged
merged 6 commits into from
Jul 22, 2020

Conversation

jjgonecrypto
Copy link
Contributor

@jjgonecrypto jjgonecrypto commented Jul 4, 2020

Closes #579

@codecov
Copy link

codecov bot commented Jul 5, 2020

Codecov Report

Merging #584 into develop will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #584      +/-   ##
===========================================
- Coverage    99.46%   99.46%   -0.01%     
===========================================
  Files           44       44              
  Lines         2798     2792       -6     
  Branches       395      395              
===========================================
- Hits          2783     2777       -6     
  Misses          15       15              
Impacted Files Coverage Δ
contracts/MultiCollateralSynth.sol 100.00% <ø> (ø)
contracts/Synth.sol 98.82% <100.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb15e88...d5761df. Read the comment docs.

@zyzek
Copy link
Contributor

zyzek commented Jul 6, 2020

Looks good. Does this mean also that the Synth contract doesn't need Synthetix as a mock in setup.js?

{
contract: 'Synth',
mocks: ['Issuer', 'Exchanger', 'FeePool', 'Synthetix'],
deps: ['TokenState', 'ProxyERC20', 'SystemStatus', 'AddressResolver'],
}, // a generic synth

@hav-noms
Copy link
Contributor

hav-noms commented Jul 6, 2020

LGTM anything else to add to this?

@jjgonecrypto jjgonecrypto marked this pull request as ready for review July 6, 2020 14:44
@jjgonecrypto jjgonecrypto merged commit edc6e37 into develop Jul 22, 2020
@jjgonecrypto jjgonecrypto deleted the synth-no-need-synthetix branch July 22, 2020 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants