-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: various functions #557
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To determine if reaction is reversible, consider all combinations of LB and UB, not just whether LB < 0 or not
This PR has been automatically tested with GH Actions. Here is the output of the tests: > Installation type Advanced (via git)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
importModel
allows for empty parameters when not specifiedconstructS
gives correct error message when a metabolite is missingimportExcelModel
can ignore faulty MIRIAM entries (note: import of Excel models is strongly discouraged!)checkModelStruct
to determine if reaction is reversible, consider all combinations of LB and UB, not just whether LB < 0 or notcheckModelStruct
checks that all genes ingrRules
field are also ingenes
field (solves checkModelStruct should compare .genes and .grRules #556)getKEGGModelForOrganism
explicitly refers to the correctdataDir
options (i.e.prok90_kegg105
oreuk90_kegg105
at this time)getExchangeRxns
has more options to select reactions based on their reaction bounds, whether they represent uptake, excretion etc. (solves getExchangeRxns.m works inconsistently #555)Instructions on merging this PR:
develop
as target branch, and will be resolved with a squash-merge.main
as target branch, and will be resolved with a merge commit.