Skip to content

GH-744 - Self Review #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 113 commits into
base: master
Choose a base branch
from
Open

GH-744 - Self Review #1

wants to merge 113 commits into from

Conversation

Syther007
Copy link
Owner

No description provided.

@Syther007
Added base comments
e908666
@Syther007
GH-744: removed .wait() from handle_request_balances_to_pay_payables
8b71081
@Syther007
GH-744: added future return type to get_transaction_fee_balance
99e36a5
@Syther007
Fixed error mapping for .get_token_balance
4fba6f1
@Syther007
GH-744: Fixed failing tests, all tests passing
7d0d075
@Syther007
GH-744: Added future return to ReportAccountsPayable
159ad22
@Syther007
GH-744: Fixed more errors
5b25bce
@Syther007
GH-744: Added batch lifetime
ffe6b81
@Syther007
Revert "GH-744: Added batch lifetime"
cb2f3e4 
This reverts commit ffe6b81.
@Syther007
GH-744: Fixed more errors
e5482f7
@Syther007
GH-744: small clean up
8093caf
@Syther007
GH-744: Moved batch_payable_tools functions
85529d0
@Syther007
GH-744: send_payables_within_batch accounts changed to Vec
aa811db
@Syther007
GH-744: added blockchain_interface_slim
d1659ec
@Syther007
Added blockchain_interface_utils.js
0877056
@Syther007
GH-744: process_payments is working with futures
a075b5d
@Syther007
GH-744: Fixed a few more tests in blockchain_interface_utils
70ee731
@Syther007
GH-744: Fixed test useing test_gas_limit_is_between_limits
2f03dbe
@Syther007
Changed sign_transaction_data amount data type to u128
ba6a7f9
@Syther007
GH-744 converted handle_retrieve_transactions return type to future
c7725b1
@Syther007
GH-744: Fixed some error with handle_retrieve_transactions
2a16982
@Syther007
GH-744: update_start_block_message_works test works
93189ec
@Syther007
GH-744: Added get_batch_web3 Mock
231cce3
@Syther007
GH-744: Fixed test report_accounts_payable_returns_error_fetching_pen…
25593c5 
…ding_nonce
@Syther007
GH-744: fixed test process_payments_returns_error_from_sending_batch
c313533
@Syther007
GH-744: fixed test handle_report_accounts_payable_transmits_eleventh_…
e771cd5 
…hour_error_back_to_accountant
@Syther007
GH-744: Edited test handle_report_accounts_payable_transacts_and_send…
d3a3694 
…s_finished_payments_back_to_accountant
@Syther007
GH-744: updated test handle_report_accounts_payable_transacts_and_sen…
6c6a146 
…ds_finished_payments_back_to_accountant
@Syther007
GH-744: FIxed test handle_retrieve_transactions_sends_received_paymen…
e645549 
…ts_back_to_accountant
@Syther007
GH-744: Update to test processing_of_received_payments_continues_even…
5e1dac1 
…_if_no_payments_are_detected
Syther007 added 26 commits June 25, 2024 21:48
@Syther007
GH-744: all tests within lower_level_interface are now working
7fb5a3b
@Syther007
GH-744: Moved get_transaction_receipt_batch to lower_level_interface
a32fabe
@Syther007
GH-744: Added tests for transaction_receipt_batch
cee7825
@Syther007
GH-744: All tests passing on blockchain_birdge
df499b6
@Syther007
GH-744: added fn get_transaction_logs to lower_level_interface
c6c79f4
@Syther007
GH-744: added fn submit_payables_in_batch to lower_level_interface
591e074
@Syther007
GH-744: removed unnecessary functions from BlockchainInterface
1d9dffc
@Syther007
GH-744: Todo clean up
236247c
@Syther007
GH-744: test: pending_transaction_is_registered_and_monitored_until_i…
3108a0b 
…t_gets_confirmed_or_canceled is working
@Syther007
GH-744: clean up & all tests pasing
00661b8
@Syther007
GH-744: cleanup of more todos
108fbaa
@Syther007
Merge branch 'master' of https://github.com/MASQ-Project/Node into GH…
ff74544 
…-744-merge-test
@Syther007
GH-744: Compiling after merge
2288287
@Syther007
GH-744: all but 1 tests are passing after merge
00cc396
@Syther007
GH-744: Fixed pending_transaction_is_registered_and_monitored_until_i…
f904a71 
…t_gets_confirmed_or_canceled again
@Syther007
GH-744: Removed all warnings
b60a6a8
@Syther007
GH-744: Formatting
5598918
@Syther007
GH-744: fixed all clippys warnings
01ff73c
@Syther007
GH-744: multinode tests running, but failing on MBCS
8a3f1e7
@Syther007
GH-744 fixed more multinode tests
fed2a85
@Syther007
GH-744: Added check for wildcard ip inside neighborhood
cfdb772
@Syther007
GH-744: Fixed all multinode intergration tests
d54a3d0
@Syther007
GH-744: All tests are passing!
e677373
@Syther007
GH-744: fixed test send_payables_within_batch_fails_on_submit_batch_c…
1f5940d 
…all for windows
@Syther007
GH-744: fixed handle_scan_future tests
0ea951c
@Syther007
GH-744: Added a fallback blockchain_service_url
aee1544
Syther007
Syther007 commented Sep 3, 2024
View reviewed changes
Copy link
Owner Author

@Syther007 Syther007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed files with small changes

Syther007
Syther007 commented Sep 4, 2024
View reviewed changes
Copy link
Owner Author

@Syther007 Syther007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node/src/blockchain/blockchain_bridge.rs Line: 157

Syther007
Syther007 commented Sep 4, 2024
View reviewed changes
Copy link
Owner Author

@Syther007 Syther007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stop at node/src/blockchain/blockchain_bridge.rs 1565

Syther007
Syther007 commented Sep 9, 2024
View reviewed changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Syther007 @utkarshg6