Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WP-865 - Fix to make trash command in shared workspace work again #1049

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chandra-tacc
Copy link
Collaborator

@chandra-tacc chandra-tacc commented Feb 4, 2025

Overview

Shared workspaces need a bit better handling for system and homeDir during trash operations.
See here and here on how this code worked before regression

Related

Changes

  1. Set homedir to empty if not available. For shared workspaces, this translates to root. And .trash is at root. See here
  2. Get the system from the first selected file if selectedSystem is not applicable (in case of shared workspace).

Testing

  1. Trash a file in shared workspace
  2. Trash a file in any other data file.

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 70.37%. Comparing base (96eb02e) to head (f4b5b90).

Files with missing lines Patch % Lines
...ts/DataFiles/DataFilesToolbar/DataFilesToolbar.jsx 16.66% 5 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1049      +/-   ##
==========================================
- Coverage   70.38%   70.37%   -0.01%     
==========================================
  Files         538      538              
  Lines       33313    33315       +2     
  Branches     2955     2954       -1     
==========================================
- Hits        23446    23445       -1     
- Misses       9669     9672       +3     
  Partials      198      198              
Flag Coverage Δ
javascript 72.53% <16.66%> (-0.01%) ⬇️
unittests 61.13% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ts/DataFiles/DataFilesToolbar/DataFilesToolbar.jsx 80.24% <16.66%> (-1.09%) ⬇️

@chandra-tacc chandra-tacc marked this pull request as ready for review February 4, 2025 17:42
@chandra-tacc chandra-tacc changed the title WP-865 - sending file to trash in shared workspaces WP-865 - Fix to make trash command in shared workspace work again Feb 4, 2025
Copy link
Collaborator

@jarosenb jarosenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this matches how we do things in Designsafe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants