Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requested changes to Analysis Dataset view #1056

Open
wants to merge 2 commits into
base: task/digital-rocks
Choose a base branch
from

Conversation

van-go
Copy link
Contributor

@van-go van-go commented Feb 13, 2025

Overview

Requested Changes to "Add Analysis Dataset" view

Related

Changes

Remove the “Description” field.

Replace the label “Base Sample” with “Reference Sample”.

Replace the label “Digital Dataset” with “Reference Digital Dataset”.

    Add a drop-down menu pointing to existing datasets or “Other”.

    If a user selects Other, they are provided with a free entry field to enter more information.

Add a field labeled “Other Information” to the bottom of the view (which should not be required).

Add a list of descriptions for each field that needs to be populated:

    Reference Sample: “The sample that was analyzed.”

    Reference Digital Dataset: “The DOI or URI of an existing public dataset from DPMP or another repository that is used for the analysis dataset.”

    Analysis Type: 

        Machine Learning: “The dataset includes the analysis results coming from machine learning, deep learning, reinforcement learning, or any type of artificial intelligence algorithm.”

        Simulation: “The dataset includes numerical/analytical simulation results.”

        Experimental: “The dataset includes laboratory-based experiment results.”

        Characterization: “The dataset includes digital characterization results.”

        Other: “Specify the analysis type that the analysis dataset includes.”

    Other Information: “Information that the authors find relevant to the analysis, such as the labels for segmentation, analysis details, etc.”

Testing

  1. Pull up the Add Analysis Dataset modal and verify requested changes are there.

UI

Notes

@van-go van-go requested review from taoteg and shayanaijaz February 13, 2025 18:20
Copy link
Contributor

@shayanaijaz shayanaijaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just need to remove the console.log statements and commented out code then it should be good to merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants