Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task/WP-834 - Add behavior for ignoring DesignSafe-Corral allocation for running jobs #1057

Merged
merged 3 commits into from
Feb 21, 2025

Conversation

fnets
Copy link
Contributor

@fnets fnets commented Feb 14, 2025

Overview

Added changes to remove TAS projects that are purely administrative from default allocations, as they were preventing a few users from running jobs.

Related

Changes

  • A setting that allows us to configure which projects should be removed, which defaults to DesignSafe-DCV and DesignSafe-Corral

Testing

Difficult to test, because either of those projects will need to be your default allocation to see the change, BUT

  1. Run a job that needs DCV and a job like compress/extract that doesn't allow you to pick the allocation that you run against.
  2. Make sure the job submits successfully.

UI

Notes

…rom default allocations, as they were preventing a few users from running jobs.
Copy link

codecov bot commented Feb 14, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 70.37%. Comparing base (96eb02e) to head (cfd9039).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
server/portal/apps/users/views.py 0.00% 2 Missing ⚠️
server/portal/settings/settings.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1057      +/-   ##
==========================================
- Coverage   70.38%   70.37%   -0.01%     
==========================================
  Files         538      538              
  Lines       33313    33316       +3     
  Branches     2955     2956       +1     
==========================================
  Hits        23446    23446              
- Misses       9669     9672       +3     
  Partials      198      198              
Flag Coverage Δ
javascript 72.54% <ø> (ø)
unittests 61.10% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
server/portal/settings/settings.py 0.00% <0.00%> (ø)
server/portal/apps/users/views.py 57.48% <0.00%> (-0.70%) ⬇️

Copy link
Collaborator

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor comment

@chandra-tacc
Copy link
Collaborator

LGTM, just one minor comment
I did a live comment of the minor comment. So, all good

Copy link
Contributor

@edmondsgarrett edmondsgarrett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this addition!

@chandra-tacc chandra-tacc merged commit 7cfdea2 into main Feb 21, 2025
4 of 6 checks passed
@chandra-tacc chandra-tacc deleted the task/WP-834 branch February 21, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants