Add ARIA labels to Home page - Vanilla.js #95 #325
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…component; update tests to verify accessibility features
29deepanshutyagi
requested review from
acekyd,
leordev and
blackgirlbytes
as code owners
|
@29deepanshutyagi Thanks for your contribution, but this particular issue is premature. I appreciate that you've been working on this particular project, but let me show you the end goal of this application. Both the React version of this app and the Vue version look like this image The JavaScript version doesn't look like this yet. So we want to complete the components FIRST before we add any ARIA labels or accessibility because if we add the accessibility now. Because right now the home page doesn't have anything on it. Secondly, this PR has a couple of errors in it where you had merge conflicts So if possible, could you work on the sidebar page and the homepage BEFORE doing any ARIA label PRs. Thank you!!! |
|
sure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue #95