[#12048] Refactor tests for DeleteFeedbackQuestionActionTest (#13246)

* Refactor test case initialisation Remove final fields and create a method to initialise the variables before the test, so as to reduce dependencies. (cherry picked from commit 1dc9742) * Rectify import classes Imported BeforeEach from JUnit previously, instead of BeforeMethod --------- Co-authored-by: domoberzin <[email protected]>
TEAMMATES · Feb 28, 2025 · ca4f178 · ca4f178
1 parent e9a0ea0
commit ca4f178
Showing 1 changed file with 13 additions and 5 deletions.
diff --git a/src/test/java/teammates/sqlui/webapi/DeleteFeedbackQuestionActionTest.java b/src/test/java/teammates/sqlui/webapi/DeleteFeedbackQuestionActionTest.java
@@ -5,6 +5,7 @@
 
 import java.util.UUID;
 
+import org.testng.annotations.BeforeMethod;
 import org.testng.annotations.Test;
 
 import teammates.common.datatransfer.InstructorPrivileges;
@@ -21,11 +22,10 @@
  */
 public class DeleteFeedbackQuestionActionTest extends BaseActionTest<DeleteFeedbackQuestionAction> {
 
-    private final Instructor typicalInstructor = getTypicalInstructor();
-    private final Course typicalCourse = typicalInstructor.getCourse();
-    private final FeedbackSession typicalFeedbackSession = getTypicalFeedbackSessionForCourse(typicalCourse);
-    private final FeedbackQuestion typicalFeedbackQuestion =
-            getTypicalFeedbackQuestionForSession(typicalFeedbackSession);
+    private Instructor typicalInstructor;
+    private Course typicalCourse;
+    private FeedbackSession typicalFeedbackSession;
+    private FeedbackQuestion typicalFeedbackQuestion;
 
     @Override
     protected String getActionUri() {
@@ -37,6 +37,14 @@ protected String getRequestMethod() {
         return DELETE;
     }
 
+    @BeforeMethod
+    void setUp() {
+        typicalInstructor = getTypicalInstructor();
+        typicalCourse = typicalInstructor.getCourse();
+        typicalFeedbackSession = getTypicalFeedbackSessionForCourse(typicalCourse);
+        typicalFeedbackQuestion = getTypicalFeedbackQuestionForSession(typicalFeedbackSession);
+    }
+
     @Test
     void testExecute_feedbackQuestionExists_success() {
         when(mockLogic.getFeedbackQuestion(typicalFeedbackQuestion.getId())).thenReturn(typicalFeedbackQuestion);