Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Migrate Tests for DeleteStudentActionTest #13204

Merged
merged 16 commits into from
Feb 18, 2025
Merged

[#12048] Migrate Tests for DeleteStudentActionTest #13204

merged 16 commits into from
Feb 18, 2025

Conversation

DhiraPT
Copy link
Contributor

@DhiraPT DhiraPT commented Jan 26, 2025

Part of #12048

Outline of Solution
Migrated DeleteStudentActionTest to use SQL-based logic instead of the previous Datastore model.

@github-actions GitHub Actions
Copy link

Hi @DhiraPT, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

dishenggg
dishenggg requested changes Feb 13, 2025
View reviewed changes
Copy link
Contributor

@dishenggg dishenggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Sorry for late review just a few small changes

@dishenggg dishenggg mentioned this pull request Feb 13, 2025
Merged
@dishenggg dishenggg added the s.Ongoing The PR is being worked on by the author(s) label Feb 13, 2025
dishenggg
dishenggg requested changes Feb 14, 2025
View reviewed changes
Copy link
Contributor

@dishenggg dishenggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like I was a bit confused with when the logic is called, but you got the idea!

Just one more minor change

dishenggg
dishenggg approved these changes Feb 15, 2025
View reviewed changes
Copy link
Contributor

@dishenggg dishenggg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dishenggg dishenggg added s.FinalReview The PR is ready for final review and removed s.Ongoing The PR is being worked on by the author(s) labels Feb 15, 2025
@DhiraPT DhiraPT force-pushed the db-migrate-tests branch 2 times, most recently from 1aa6b9c to 7ee55b2 Compare February 16, 2025 05:17
jasonqiu212
jasonqiu212 approved these changes Feb 18, 2025
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jasonqiu212 jasonqiu212 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Feb 18, 2025
@jasonqiu212 jasonqiu212 merged commit c4390f2 into TEAMMATES:master Feb 18, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dishenggg dishenggg dishenggg approved these changes

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

@xenosf xenosf Awaiting requested review from xenosf

Assignees

@DhiraPT DhiraPT

Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DhiraPT @dishenggg @jasonqiu212