[#12048] Migrate tests #13206
Merged
[#12048] Migrate tests #13206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mingyang143
force-pushed
the
branch-migrate-tests-week3
branch
from
c421a54 to
7f0321d
Compare
dishenggg
requested changes
Feb 9, 2025
src/test/java/teammates/sqlui/webapi/DeleteFeedbackSessionActionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/teammates/sqlui/webapi/DeleteFeedbackSessionActionTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
34
to
36
| Course course; | ||
| Team team; | ||
| Section section; |
There was a problem hiding this comment.
small nit lets private these for consistency too
src/test/java/teammates/sqlui/webapi/EnrollStudentsActionTest.java
Outdated
Show resolved
Hide resolved
dishenggg
approved these changes
Feb 11, 2025
src/test/java/teammates/sqlui/webapi/DeleteFeedbackSessionActionTest.java
Show resolved
Hide resolved
dishenggg
added
s.FinalReview
mingyang143
force-pushed
the
branch-migrate-tests-week3
branch
from
59933f3 to
645e6ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
Change EnrollStudentsActionTest.java and DeleteFeedbackSessionActionTest.java to ensure compatibility with the PostgreSQL database following the database migration.