Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#12048] Migrate Tests for DeleteInstructorActionTest #13207

Merged
merged 16 commits into from
Mar 3, 2025
Merged

[#12048] Migrate Tests for DeleteInstructorActionTest #13207

merged 16 commits into from
Mar 3, 2025

Conversation

DhiraPT
Copy link
Contributor

@DhiraPT DhiraPT commented Jan 30, 2025

Part of #12048

Outline of Solution
Migrated DeleteInstructorActionTest to use SQL-based logic instead of the previous Datastore model.

@github-actions GitHub Actions
Copy link

Hi @DhiraPT, thank you for your interest in contributing to TEAMMATES!
However, your PR does not appear to follow our contribution guidelines:

  • Description must reference the issue number the PR is fixing, e.g. Fixes #<issue-number> (or Part of #<issue-number> if the PR does not address the issue fully)

Please address the above before we proceed to review your PR.

jasonqiu212
jasonqiu212 approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jasonqiu212 jasonqiu212 added the s.FinalReview The PR is ready for final review label Feb 19, 2025
xenosf
xenosf approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@xenosf xenosf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good work migrating the tests and rewriting them to be a lot clearer and isolated

xenosf
xenosf previously requested changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@xenosf xenosf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, missed one thing in my previous review! Looks good other than that :)

@jasonqiu212 jasonqiu212 requested a review from xenosf February 24, 2025 10:17
domoberzin
domoberzin approved these changes Mar 1, 2025
View reviewed changes
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can merge this in 😃

@domoberzin domoberzin dismissed xenosf’s stale review March 3, 2025 05:06

Already resolved, will dismiss so this can be merged in :)

@domoberzin domoberzin merged commit c72ca17 into TEAMMATES:master Mar 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasonqiu212 jasonqiu212 jasonqiu212 approved these changes

@domoberzin domoberzin domoberzin approved these changes

@dishenggg dishenggg Awaiting requested review from dishenggg

@xenosf xenosf Awaiting requested review from xenosf

Assignees
No one assigned
Labels
s.FinalReview The PR is ready for final review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DhiraPT @jasonqiu212 @xenosf @domoberzin