[#12048] Migrate tests for GetNotificationActionTest #13210
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuanxi1
reviewed
Feb 11, 2025
src/test/java/teammates/sqlui/webapi/GetNotificationActionTest.java
Outdated
Show resolved
Hide resolved
src/test/java/teammates/sqlui/webapi/GetNotificationActionTest.java
Outdated
Show resolved
Hide resolved
Comment on lines
+69
to
+70
| GetNotificationAction action = getAction(Const.ParamsNames.NOTIFICATION_ID, UUID.randomUUID().toString()); | ||
| EntityNotFoundException enfe = assertThrows(EntityNotFoundException.class, action::execute); |
There was a problem hiding this comment.
Minor style suggestion: Consider adding a blank line between the action and the assertions to improve readability.
Comment on lines
+76
to
+77
| GetNotificationAction action = getAction(Const.ParamsNames.NOTIFICATION_ID, null, new String[] {}); | ||
| InvalidHttpParameterException ihpe = assertThrows(InvalidHttpParameterException.class, action::execute); |
domoberzin
approved these changes
Feb 18, 2025
|
I think we can merge this in 😆 |
domoberzin
added
s.ToMerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #12048
Outline of Solution
Added the unit tests for GetNotificationActionTest for PostgreSQL.
PS: This is not a duplicate of #13219 if anyone gets confused by the similar name