Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#12048] Migrate tests for CreateFeedbackQuestionActionTest #13240

Conversation

BunnyHoppp
Copy link
Contributor

Part of #12048

Outline of Solution

Change CreateFeedbackQuestionActionTest.java to ensure compatibility with the PostgreSQL database following the database migration.

Test execute method with some positive
and negative test cases

Test checkSpecificAccessControl method
with some positive and negative test
cases
Copy link
Contributor

@domoberzin domoberzin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is fairly comprehensive, looks good to me. great work!

@domoberzin domoberzin requested a review from jasonqiu212 March 3, 2025 05:05
@jasonqiu212 jasonqiu212 added the s.FinalReview The PR is ready for final review label Mar 3, 2025
Copy link
Contributor

@jasonqiu212 jasonqiu212 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 small nit! the rest looks good 👍 thanks for the comprehensive test cases

@jasonqiu212 jasonqiu212 added s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging and removed s.FinalReview The PR is ready for final review labels Mar 3, 2025
@jasonqiu212 jasonqiu212 merged commit 2076737 into TEAMMATES:master Mar 3, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
s.ToMerge The PR is approved by all reviewers including final reviewer; ready for merging
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants