fix:fixed chat date separator issue on day's first message #1209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for teritori-dapp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for testitori ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
sachin-into
requested review from
omniwired,
n0izn0iz and
VishalRakholiya-iView
omniwired
reviewed
Apr 16, 2024
| ? moment(item.timestamp).format("DD/MM/YYYY") !== | ||
| moment(previousMessage.timestamp).format("DD/MM/YYYY") && | ||
| item.timestamp | ||
| ? moment(item.timestamp).format("DD/MM/YYYY") === |
There was a problem hiding this comment.
Why not rely on whatever the user locale is set?
I think that's more natural
omniwired
approved these changes
Apr 16, 2024
omniwired
approved these changes
Apr 18, 2024
sachin-into
force-pushed
the
fix/first-message-grouping
branch
from
d778616
to
9a33f0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #1190