Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(feed): setting zoom level when location not provided #1398

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

fix(feed): setting zoom level when location not provided #1398

wants to merge 5 commits into from

Conversation

sujal-into
Copy link
Collaborator

fix: #1367

@sujal-into sujal-into added the Social Feed Everything related to the Social Feed label Nov 19, 2024
@sujal-into sujal-into self-assigned this Nov 19, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 19, 2024 •
edited
Loading

✅ Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit 13a2ed4
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/673d9b708936650008877068
😎 Deploy Preview https://deploy-preview-1398--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 19, 2024 •
edited
Loading

✅ Deploy Preview for testitori ready!

Name Link
🔨 Latest commit 13a2ed4
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/673d9b70d96c2b00084ffb30
😎 Deploy Preview https://deploy-preview-1398--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@n0izn0iz n0izn0iz mentioned this pull request Nov 19, 2024
Open
WaDadidou
WaDadidou requested changes Nov 19, 2024
View reviewed changes
packages/components/socialFeed/Map/Map.web.tsx Outdated Show resolved Hide resolved
packages/utils/feed/map.ts Outdated Show resolved Hide resolved
packages/components/socialFeed/Map/Map.web.tsx Show resolved Hide resolved
packages/components/socialFeed/Map/Map.web.tsx Show resolved Hide resolved
@WaDadidou WaDadidou changed the title fix: setting zoom level when location not provided fix(feed): setting zoom level when location not provided Nov 21, 2024
hthieu1110
hthieu1110 approved these changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@hthieu1110 hthieu1110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@n0izn0iz n0izn0iz added this pull request to the merge queue Nov 23, 2024
@n0izn0iz n0izn0iz removed this pull request from the merge queue due to a manual request Nov 23, 2024
n0izn0iz
n0izn0iz requested changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please use the maximum responsive size instead of an arbitrary zoom level

@sujal-into
Copy link
Collaborator Author

please use the maximum responsive size instead of an arbitrary zoom level

fixed this in this pr: #1399

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WaDadidou WaDadidou WaDadidou approved these changes

@hthieu1110 hthieu1110 hthieu1110 approved these changes

@n0izn0iz n0izn0iz Awaiting requested review from n0izn0iz

Requested changes must be addressed to merge this pull request.

Assignees

@sujal-into sujal-into

Labels
Social Feed Everything related to the Social Feed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug(feed): dezoomed map by default instead of Paris
4 participants
@sujal-into @hthieu1110 @n0izn0iz @WaDadidou