Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(feed): remove AudioNote thumbnail #1404

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(feed): remove AudioNote thumbnail #1404

wants to merge 1 commit into from

Conversation

WaDadidou
Copy link
Collaborator

@WaDadidou WaDadidou commented Nov 20, 2024 •
edited by n0izn0iz
Loading

Closes #1407
Closes #1351 (refacto)

@WaDadidou WaDadidou added bug Something isn't working Social Feed Everything related to the Social Feed refacto labels Nov 20, 2024
@WaDadidou WaDadidou self-assigned this Nov 20, 2024
@netlify Netlify
Copy link

netlify bot commented Nov 20, 2024 •
edited
Loading

✅ Deploy Preview for teritori-dapp ready!

Name Link
🔨 Latest commit 667c140
🔍 Latest deploy log https://app.netlify.com/sites/teritori-dapp/deploys/673e706b2bac3a000813c659
😎 Deploy Preview https://deploy-preview-1404--teritori-dapp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify Netlify
Copy link

netlify bot commented Nov 20, 2024 •
edited
Loading

✅ Deploy Preview for testitori ready!

Name Link
🔨 Latest commit 667c140
🔍 Latest deploy log https://app.netlify.com/sites/testitori/deploys/673e706ba2d1cd0008679e81
😎 Deploy Preview https://deploy-preview-1404--testitori.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@WaDadidou WaDadidou changed the title chore(feed): Add thumbnail to Media and simplify MediaPlayerBar fix(feed): Fix AudioNote thumbnail doesn't appear in MediaPlayerBar Nov 20, 2024
n0izn0iz
n0izn0iz requested changes Nov 21, 2024
View reviewed changes
Copy link
Collaborator

@n0izn0iz n0izn0iz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please answer #1365 (comment)

@WaDadidou WaDadidou changed the title fix(feed): Fix AudioNote thumbnail doesn't appear in MediaPlayerBar fix(feed): Add thumbnail in Media Nov 21, 2024
@WaDadidou
Copy link
Collaborator Author

WaDadidou commented Nov 21, 2024 •
edited
Loading

please answer #1365 (comment)

Ok to remove the thumbnail from the audios. But not in this PR (?)
But this PR will facilitate this refacto.

BUT, I can do the refacto in this PR. <== I would prefer doing that

@n0izn0iz
Copy link
Collaborator

sure, target this issue now then #1407

@n0izn0iz n0izn0iz changed the title fix(feed): Add thumbnail in Media feat(feed): remove AudioNote thumbnail Nov 21, 2024
@WaDadidou
Copy link
Collaborator Author

After reflexion, I think we should keep it. It's a feature.
We'll make brainstorm to rework the posts data and lock it

hthieu1110
hthieu1110 approved these changes Nov 23, 2024
View reviewed changes
Copy link
Collaborator

@hthieu1110 hthieu1110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@n0izn0iz n0izn0iz n0izn0iz requested changes

@hthieu1110 hthieu1110 hthieu1110 approved these changes

@MikaelVallenet MikaelVallenet Awaiting requested review from MikaelVallenet

@sujal-into sujal-into Awaiting requested review from sujal-into

@omarsy omarsy Awaiting requested review from omarsy

@Villaquiranm Villaquiranm Awaiting requested review from Villaquiranm

Requested changes must be addressed to merge this pull request.

Assignees

@WaDadidou WaDadidou

Labels
bug Something isn't working refacto Social Feed Everything related to the Social Feed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat(feed): remove AudioNote thumbnail chore(feed): Add thumbnail to Media interface
3 participants
@WaDadidou @n0izn0iz @hthieu1110