fix: Handle Gno network switch modal

[hthieu1110]

Fix issue: #1380

[netlify]

✅ Deploy Preview for gno-dapp ready!

Name	Link
🔨 Latest commit	777291d
🔍 Latest deploy log	https://app.netlify.com/sites/gno-dapp/deploys/67471b2644923d0008a92f8a
😎 Deploy Preview	https://deploy-preview-1424--gno-dapp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[netlify]

✅ Deploy Preview for teritori-dapp ready!

Name	Link
🔨 Latest commit	777291d
🔍 Latest deploy log	https://app.netlify.com/sites/teritori-dapp/deploys/67471b264019620008b08cc1
😎 Deploy Preview	https://deploy-preview-1424--teritori-dapp.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[n0izn0iz]

Looks good, except there is a weird behavior when you connect for the first time (when the app is not authorized yet) and you are on the wrong gno network (for example, adena is on test5 and the app is on portal loop)

[n0izn0iz]

still have the same behavior, please read the previous comment carefully to reproduce

you need to remove the authorization in this list to reproduce

[WaDadidou]

Same on deploy-preview-1424--gno-dapp et deploy-preview-1424--teritori-dapp:

I have this:

When I click Connect, I have an infinite loading:

When I close the wallet window, I got this error :

Uncaught (in promise) TypeError: Cannot read properties of null (reading 'chainId')

[hthieu1110]

Same on deploy-preview-1424--gno-dapp et deploy-preview-1424--teritori-dapp:

I have this:

When I click Connect, I have an infinite loading:

When I close the wallet window, I got this error :

Uncaught (in promise) TypeError: Cannot read properties of null (reading 'chainId')

I'm not able to reproduce this. Step I've tried:

• Open the dapp with unauthorized wallet
• Select Gno Test 5 while in Adena it's Portal loop
• Connect with Adena
  => it shows only the error that Norman mentioned above

[hthieu1110]

still have the same behavior, please read the previous comment carefully to reproduce

you need to remove the authorization in this list to reproduce

Okie, I've push the fix and cover some other edge-cases also.

[WaDadidou]

@hthieu1110 , Ok, I was not on Portal Loop ! Your fix works on my side :)

[WaDadidou]

@hthieu1110 I got this error when the Adena Switch modal is open, BUT I click on "Connect Wallet" then "Adena Wallet"

I think we should alway show the loader in ConnectWalletButton when a wallet window in open, to prevent the user from breaking the UI if he doesn't interact with the wallet extension.

Maybe out of scope

[hthieu1110]

@hthieu1110 I got this error when the Adena Switch modal is open, BUT I click on "Connect Wallet" then "Adena Wallet"

I think we should alway show the loader in ConnectWalletButton when a wallet window in open, to prevent the user from breaking the UI if he doesn't interact with the wallet extension.

Maybe out of scope

IMHO, it's a discussion in another scope, for now, when the switch modal is open, you ask to connect to another Adena network so it's normal that it fetches the connected network from your wallet and thus close the modal. That behaviour is not really related to this Pr.

[n0izn0iz]

actually @WaDadidou is right, this is why we were calling getAccount in the button handler

but fixing this issue is more important than the problem of introducing this regression so we can merge as-is and open another issue IMO

[n0izn0iz]

Following the same flow as before (first connection, wrong network):
if you cancel the "switch network" request in adena, the "Connect wallet" button then does nothing

[n0izn0iz]

I recommend you try testing in "adversarial mode", thinking about way to break the flow before asking for new reviews

[hthieu1110]

I recommend you try testing in "adversarial mode", thinking about way to break the flow before asking for new reviews

Of course testing all the flow possible on my side is what I have done firstly before asking the review. I've tested all the cases that I think about and there are edge cases that I dont even know